Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: changed paddings in sfselect #2864

Merged
merged 4 commits into from
Jun 29, 2023
Merged

Conversation

aniamusial
Copy link
Contributor

@aniamusial aniamusial commented Jun 26, 2023

Related issue

https://vsf.atlassian.net/browse/SFUI2-1226?atlOrigin=eyJpIjoiNzEwZDQ2Yzg5N2NiNDhkZWI1MWYxZDE3NjlkYzJhYjAiLCJwIjoiaiJ9

Scope of work

  • adjusted paddings for select to 12px

Screenshots of visual changes

Checklist

  • Self code-reviewed
  • Changes documented
  • Semantic HTML
  • SSR-friendly
  • Caching friendly
  • a11y for WCAG 2.0 AA
  • examples created
  • blocks created
  • cypress tests created

@changeset-bot
Copy link

changeset-bot bot commented Jun 26, 2023

🦋 Changeset detected

Latest commit: b55a4d3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@storefront-ui/react Major
@storefront-ui/vue Major
@storefront-ui/nuxt Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aniamusial aniamusial marked this pull request as ready for review June 26, 2023 08:07
@sonarqubecloud
Copy link

[storefront-ui-react] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[storefront-ui-vue] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Base automatically changed from v2-release/3.0.0 to v2-develop June 27, 2023 13:52
Co-authored-by: Jakub Freisler <jakub@frsource.org>
@aniamusial aniamusial changed the base branch from v2-develop to changeset-release/v2-release/3.0.0 June 28, 2023 11:06
@aniamusial aniamusial changed the title fix: breaking change - changed paddings in sfselect BREAKING CHANGE: changed paddings in sfselect Jun 29, 2023
@aniamusial aniamusial changed the title BREAKING CHANGE: changed paddings in sfselect fix!: changed paddings in sfselect Jun 29, 2023
@aniamusial aniamusial changed the base branch from changeset-release/v2-release/3.0.0 to v2-release/3.0.0 June 29, 2023 08:58
@sonarqubecloud
Copy link

[storefront-ui-react] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[storefront-ui-vue] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aniamusial aniamusial merged commit a2bb3a2 into v2-release/3.0.0 Jun 29, 2023
@aniamusial aniamusial deleted the fix/sfui2-1226 branch June 29, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants