Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

feat: add MegaMenu component #593

Merged
merged 22 commits into from
May 7, 2020
Merged

feat: add MegaMenu component #593

merged 22 commits into from
May 7, 2020

Conversation

Michal-Dziedzinski
Copy link
Collaborator

Changes

SfMegaMenu implemented as new TopNavigation menu

megamenu

Checklist

@github-actions
Copy link

github-actions bot commented Apr 8, 2020 •
edited
Loading

💙 shopware-pwa successfully deployed at https://e7f92621b03365b266dbd589bf558cbceacc0a91.shopware-pwa.preview.storefrontcloud.io

@patzick patzick mentioned this pull request Apr 14, 2020
Closed
3 tasks
akrajna
akrajna suggested changes Apr 14, 2020
View reviewed changes
Copy link
Collaborator

@akrajna akrajna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subcategories - 'Test Subcategory 1' and 'Test subcategory 2' of 'Cloting' - 'Movies and Toys' on our page are not visible, as below:
MegaMenu

The subcategories are visible in Shopware as below:
MegaMenuShopware

patzick
patzick suggested changes Apr 14, 2020
View reviewed changes
Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top menu categories are repeated

image

@patzick
Copy link
Collaborator

patzick commented Apr 14, 2020

even worse on page refresh

image

@mbaran-dvnt
Copy link

Zrzut ekranu 2020-04-19 o 22 15 14

Let me know if that's what you need.

@Michal-Dziedzinski
Copy link
Collaborator Author

@mbaran-dvnt if it is related to vuestorefront/storefront-ui#1029 based on this screen I can't say if this solves our problem.

@vercel vercel bot temporarily deployed to preview April 27, 2020 14:10 Inactive
@vercel
Copy link

vercel bot commented Apr 27, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/5ps36puht
✅ Preview: https://shopware-pwa-docs-git-feature-8-sfmegamenu-component.shopware-pwa.now.sh

@vercel vercel bot temporarily deployed to preview April 27, 2020 14:48 Inactive
@vercel vercel bot temporarily deployed to preview April 29, 2020 12:51 Inactive
@vercel vercel bot temporarily deployed to preview April 29, 2020 15:49 Inactive
@patzick patzick added this to the v0.1.0-alpha.5 milestone May 6, 2020
@vercel vercel bot temporarily deployed to preview May 6, 2020 13:57 Inactive
@vercel vercel bot temporarily deployed to preview May 6, 2020 17:11 Inactive
@akrajna
Copy link
Collaborator

akrajna commented May 7, 2020

If there is a lot of subcategories they are nor all visible e.g. in category Sport there are 8 active
subcategories but on the page we can see 6 and half.
MegaMenuSubcategory
MegaMenuSubcategories2

@vercel vercel bot temporarily deployed to preview May 7, 2020 08:06 Inactive
@vercel vercel bot temporarily deployed to preview May 7, 2020 08:33 Inactive
@patzick patzick merged commit f6167d5 into master May 7, 2020
@patzick patzick deleted the feature/8-SfMegaMenu-component branch May 7, 2020 08:34
@patzick
Copy link
Collaborator

patzick commented May 7, 2020

closes #8

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@patzick patzick patzick approved these changes

@mkucmus mkucmus Awaiting requested review from mkucmus

@akrajna akrajna Awaiting requested review from akrajna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.1.0-alpha.5
Development

Successfully merging this pull request may close these issues.
6 participants
@Michal-Dziedzinski @patzick @mbaran-dvnt @akrajna @mkucmus @martaradziszewska