Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

feat(helpers): extract messages from API error in case of 400 #518

Merged
merged 4 commits into from
Mar 20, 2020

Conversation

mkucmus
Copy link
Collaborator

@mkucmus mkucmus commented Mar 19, 2020

Part of work of #507

covers only helpers package

Checklist

  • I followed code and contributing guidelines
  • I wrote all needed tests

@mkucmus mkucmus requested a review from patzick March 19, 2020 12:27
@github-actions
Copy link

💙 shopware-pwa successfully deployed at https://00f444377a54dc7e4c7a120128205a5ee1773494.shopware-pwa.preview.storefrontcloud.io

Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just small corrections here :)

packages/helpers/src/error/index.ts Outdated Show resolved Hide resolved
packages/helpers/src/error/index.ts Show resolved Hide resolved
@patzick
Copy link
Collaborator

patzick commented Mar 20, 2020

great work! 👍

@patzick patzick merged commit 38b431e into master Mar 20, 2020
@patzick patzick deleted the feat/create-account-from-personal-details-step-#507 branch March 20, 2020 08:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants