Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

fix(composable): attach entire error object #362

Merged
merged 1 commit into from
Feb 5, 2020
Merged

Conversation

mkucmus
Copy link
Collaborator

@mkucmus mkucmus commented Feb 5, 2020

Fixes displaying 500 error page on 404 errors (from page resolver)

Changes

Screenshots of visual changes

Checklist

  • I followed code and contributing guidelines
  • I wrote all needed tests

@mkucmus mkucmus requested a review from krskibin February 5, 2020 13:19
@github-actions
Copy link

github-actions bot commented Feb 5, 2020

Deploy preview for website ready!

Built with commit d645103

https://shopware-pwa-2bsitcq32.now.sh

Copy link
Collaborator

@krskibin krskibin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! 👍

@mkucmus mkucmus merged commit 84bca64 into master Feb 5, 2020
@mkucmus mkucmus deleted the fix/error-handler branch February 5, 2020 13:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants