This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
feat: PoC - prevent displaying redundant product options #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for website ready! Built with commit 2d6d65a |
krskibin
suggested changes
Feb 3, 2020
packages/shopware-6-client/__tests__/helpers/convertAssociations.spec.ts
Outdated
Show resolved
Hide resolved
packages/shopware-6-client/__tests__/helpers/convertSearchCriteria.spec.ts
Show resolved
Hide resolved
packages/shopware-6-client/__tests__/helpers/convertSearchCriteria.spec.ts
Show resolved
Hide resolved
packages/shopware-6-client/__tests__/helpers/convertSearchCriteria.spec.ts
Show resolved
Hide resolved
added 4 commits
February 3, 2020 16:05
krskibin
reviewed
Feb 5, 2020
packages/shopware-6-client/__tests__/helpers/convertAssociations.spec.ts
Show resolved
Hide resolved
krskibin
approved these changes
Feb 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
long story short: it adds extra grouping option and appropriate filtering to each query if showing parents is disabled (by default it is).