This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
Feat/client/#217 e2e api tests #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for website ready! Built with commit 0f616d5 |
krskibin
approved these changes
Dec 17, 2019
| const UNIT_TEST_PATTERNS = [ | ||
| "<rootDir>/packages/**/__tests__/**/*spec.[jt]s?(x)" | ||
| ]; | ||
| const E2E_TEST_PATTERNS = ["<rootDir>/packages/**/__e2e__/**/*spec.[jt]s?(x)"]; |
There was a problem hiding this comment.
Suggested change
| const E2E_TEST_PATTERNS = ["<rootDir>/packages/**/__e2e__/**/*spec.[jt]s?(x)"]; | |
| const E2E_TEST_PATTERNS = ["<rootDir>/packages/**/__e2e__/**/*.e2e.spec.[jt]s?(x)"]; |
There was a problem hiding this comment.
unfortunately, this could cause a scenario when someone would add tests, fire them, think that they're passing and push it
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #217