This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
feat(default-theme): slugify filter type filename #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/DpuNBJKAaantb7X7yZxKCSAytBAx |
|
💙 shopware-pwa-canary successfully deployed at https://ead2472168b4443c09424ddb77ae7ef2c08357f5.shopware-pwa-canary.preview.storefrontcloud.io |
mkucmus
force-pushed
the
feat/filter-type-access-name
branch
from
bd3fd69
to
e53b32c
Compare
patzick
approved these changes
Mar 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
properties that the filters are made of, can have name with spaces or special signs. It's better to normalize those name before to avoid spaces in names of vue components or special characters. here's my proposal of using existing helper that replaces non letter characters into "-".
Checklist