Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

refactor(default-theme): add vue extension to component imports #1385

Merged
merged 5 commits into from
Mar 3, 2021

Conversation

patzick
Copy link
Collaborator

@patzick patzick commented Mar 1, 2021

Changes

Following good practices component imports should have .vue extension:

You should always use the .vue extension when importing Vue components, as omitting the extension creates numerous problems for static analysis tools. It was a mistake to allow it in vue-cli and we will likely disable it in the future.

source: https://twitter.com/youyuxi/status/1288859415878283264

@patzick patzick requested a review from mkucmus March 1, 2021 19:23
@vercel
Copy link

vercel bot commented Mar 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/GCDT5PJKdVGsaVLPinzMAmqp9fU2
✅ Preview: https://shopware-pwa-docs-git-refactor-add-vue-extensions-shopware-pwa.vercel.app

@vercel vercel bot temporarily deployed to preview March 2, 2021 17:12 Inactive
@vercel vercel bot temporarily deployed to preview March 2, 2021 17:18 Inactive
@vercel vercel bot temporarily deployed to preview March 2, 2021 18:26 Inactive
@github-actions
Copy link

github-actions bot commented Mar 2, 2021

💙 shopware-pwa-canary successfully deployed at https://316782fd84a49f3cac38ce14cb00297d8bb56e1a.shopware-pwa-canary.preview.storefrontcloud.io

Copy link
Collaborator

@mkucmus mkucmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

welcome back! it's a huge first PR 🚀

@patzick patzick merged commit 85e334c into master Mar 3, 2021
@patzick patzick deleted the refactor/add-vue-extensions branch March 3, 2021 09:21
develth added a commit to develth/shopware-pwa that referenced this pull request Mar 19, 2021
patzick pushed a commit that referenced this pull request Mar 19, 2021
* refactor(default-theme): add .vue extension #1385
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants