fix(helpers): extract option name from translated object #1243
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/5fli2p177 |
|
💙 shopware-pwa-canary successfully deployed at https://1422098ce37f9395d3e4e21e027bf96e3cfcb218.shopware-pwa-canary.preview.storefrontcloud.io |
| if (option.group?.name) { | ||
| if (!typeOptions.hasOwnProperty(option.group.name)) { | ||
| typeOptions[option.group.name] = []; | ||
| const groupName = option.group?.translated?.name || option.group?.name; |
There was a problem hiding this comment.
I think we've got a couple of places left in our code, where we go straight for the property instead of the translated.property. We should, in general, always go for the translated field and never use the original field of any entity.
Changes
Always try to use the translated label/name of an option. If it's not possible, use the entity's name directly.
Checklist