Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

feat(theme-base): theme base package as a foundation for custom themes #1170

Merged
merged 6 commits into from
Oct 13, 2020

Conversation

patzick
Copy link
Collaborator

@patzick patzick commented Oct 12, 2020

Changes

related #1158

prepared theme-base package as a base for all themes.

Next things to do:

  1. refactor default-theme -> change structure to match theme building and publishing structure
  2. create docs with instruction on how to develop custom theme

Checklist

@patzick patzick requested a review from mkucmus October 12, 2020 10:03
@vercel
Copy link

vercel bot commented Oct 12, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/lpl0e51ry
✅ Preview: https://shopware-pwa-docs-git-fear-theme-base-functionality.shopware-pwa.vercel.app

@github-actions
Copy link

github-actions bot commented Oct 12, 2020

💙 shopware-pwa-canary successfully deployed at https://4f15560ea8733873473abaf2152500d121c6fef4.shopware-pwa-canary.preview.storefrontcloud.io

Copy link
Collaborator

@mkucmus mkucmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works really great! 🧙‍♂️

@vercel vercel bot temporarily deployed to preview October 12, 2020 11:57 Inactive
@vercel vercel bot temporarily deployed to preview October 13, 2020 08:32 Inactive
@mkucmus mkucmus merged commit e6922ff into master Oct 13, 2020
@mkucmus mkucmus deleted the fear/theme-base-functionality branch October 13, 2020 08:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants