Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

feat(cms): newsletter component #402 (#1039)Feature/newsletter template #402 #1039

Merged
merged 11 commits into from
Aug 28, 2020
Merged

feat(cms): newsletter component #402 (#1039)Feature/newsletter template #402 #1039

merged 11 commits into from
Aug 28, 2020

Conversation

Malwurf
Copy link
Collaborator

@Malwurf Malwurf commented Aug 20, 2020 •
edited
Loading

Changes

closes #402

Checklist

@Malwurf Malwurf requested a review from akrajna August 20, 2020 19:30
@vercel
Copy link

vercel bot commented Aug 20, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/265g2dbo3
✅ Preview: https://shopware-pwa-docs-git-feature-newsletter-template-402.shopware-pwa.vercel.app

@github-actions
Copy link

github-actions bot commented Aug 20, 2020 •
edited
Loading

💙 shopware-pwa-canary successfully deployed at https://f9feb6ba210f82863b0ea4bb7d9465cf3f918c08.shopware-pwa-canary.preview.storefrontcloud.io

@vercel vercel bot temporarily deployed to preview August 20, 2020 19:49 Inactive
akrajna
akrajna suggested changes Aug 21, 2020
View reviewed changes
Copy link
Collaborator

@akrajna akrajna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The string 'Email address' is invisible if user use auto fill option to put his email address

  2. User does not get any success notification
    Newsletter

  3. The error notification is illegible

NewslettterErrorNotification

  1. The distance between 'Subscribe' button and the input field is too big

NewsletterDistance

@Malwurf
feat(default-theme): fixes after cr
50599fc 
Added thank you callback
Styled autofill input on webkit browsers
Fixed some styles
@vercel vercel bot temporarily deployed to preview August 24, 2020 10:57 Inactive
@Malwurf Malwurf requested a review from akrajna August 24, 2020 10:59
akrajna
akrajna suggested changes Aug 25, 2020
View reviewed changes
Copy link
Collaborator

@akrajna akrajna left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • after entering valid email address, the message 'storefrontUrt: The value you selected is not a valid choice' appears. There should not be such message. There should be information about successful subscription to newsletter

NewsletterStorfrontMessage

  • after entering valid email address, there is no success message

  • after entering invalid email address, the message 'Please fill form data' appears. There should not be such message, only 'Please enter a valid email address' should appear

NewsletterErrorMessageForm

@vercel vercel bot temporarily deployed to Preview August 26, 2020 11:15 Inactive
@vercel vercel bot temporarily deployed to preview August 26, 2020 11:18 Inactive
@vercel vercel bot temporarily deployed to preview August 26, 2020 12:40 Inactive
@Malwurf
Copy link
Collaborator Author

Malwurf commented Aug 26, 2020

I've fixed storefrontUrt: The value you selected is not a valid choice error display.

It can't be tested on the Canary environment until merge to master.

It is thank you message after the success subscription:
Screenshot from 2020-08-26 13-09-36 and we have another task to make it prettier here -> #1052

And removed -> 'Please fill form data' appears. information

@Malwurf Malwurf requested a review from akrajna August 26, 2020 13:16
@CLAassistant
Copy link

CLAassistant commented Aug 28, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@vercel vercel bot temporarily deployed to preview August 28, 2020 13:12 Inactive
@Malwurf
Copy link
Collaborator Author

Malwurf commented Aug 28, 2020

Newsletter bar before sends on desktop:
Screenshot from 2020-08-28 15-15-02
Screenshot from 2020-08-28 15-14-35

After sending on desktop:
Screenshot from 2020-08-28 15-15-11

Newsletter bar before sends on mobile:
Screenshot from 2020-08-28 15-15-50
Screenshot from 2020-08-28 15-15-36

After sending on mobile:
Screenshot from 2020-08-28 15-15-26

@patzick patzick merged commit 29b0a22 into master Aug 28, 2020
@patzick patzick deleted the feature/newsletter-template-#402 branch August 28, 2020 13:21
@patzick patzick changed the title Feature/newsletter template #402 feat(cms): newsletter component #402 (#1039)Feature/newsletter template #402 Aug 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@patzick patzick patzick approved these changes

@akrajna akrajna akrajna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]Home page- add 'Subscribe to Newsletters' button
4 participants
@Malwurf @CLAassistant @patzick @akrajna