fix(default-theme): product details associations problem

vuestorefront · Aug 12, 2020 · 11cb80b · 11cb80b
1 parent def73d8
commit 11cb80b
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 11 deletions.
diff --git a/packages/composables/__tests__/useCms.spec.ts b/packages/composables/__tests__/useCms.spec.ts
@@ -82,6 +82,8 @@ describe("Composables - useCms", () => {
           {
             configuration: {
               associations: [
+                { name: "productReviews" },
+                { name: "media" },
                 { associations: [{ name: "group" }], name: "options" },
               ],
               includes: getIncludesForEntity("useCms"),
@@ -102,6 +104,8 @@ describe("Composables - useCms", () => {
           {
             configuration: {
               associations: [
+                { name: "productReviews" },
+                { name: "media" },
                 { associations: [{ name: "group" }], name: "options" },
               ],
               includes: getIncludesForEntity("useCms"),
@@ -122,6 +126,8 @@ describe("Composables - useCms", () => {
           {
             configuration: {
               associations: [
+                { name: "productReviews" },
+                { name: "media" },
                 { associations: [{ name: "group" }], name: "options" },
               ],
               includes: getIncludesForEntity("useCms"),
@@ -144,6 +150,8 @@ describe("Composables - useCms", () => {
           {
             configuration: {
               associations: [
+                { name: "productReviews" },
+                { name: "media" },
                 { associations: [{ name: "group" }], name: "options" },
               ],
               includes: getIncludesForEntity("useCms"),
@@ -166,7 +174,9 @@ describe("Composables - useCms", () => {
           {
             configuration: {
               associations: [
-                { associations: [{ name: "group" }], name: "options" },
+                { name: "productReviews" },
+                { name: "media" },
+                { name: "options", associations: [{ name: "group" }] },
               ],
               includes: { product: ["name"] },
             },

diff --git a/packages/composables/src/api-params.json b/packages/composables/src/api-params.json
@@ -1,6 +1,13 @@
 {
   "useCms": {
-    "associations": [{
+    "associations": [
+      {
+        "name": "productReviews"
+      },
+      {
+        "name": "media"
+      },
+      {
       "name": "options",
       "associations": [
         {
@@ -41,6 +48,8 @@
           "config"
       ],
       "product": [
+          "media",
+          "productReviews",
           "name",
           "ratingAverage",
           "calculatedPrice",

diff --git a/packages/default-theme/components/views/ProductView.vue b/packages/default-theme/components/views/ProductView.vue
@@ -92,15 +92,6 @@ export default {
         : this.page.product
     },
   },
-  async mounted() {
-    try {
-      const { loadAssociations, product } = useProduct(this, this.page.product)
-      this.productWithAssociations = product
-      await loadAssociations()
-    } catch (e) {
-      console.error("ProductView:mounted:loadAssociations", e)
-    }
-  },
 }
 </script>
 <style lang="scss" scoped>