Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add support for configurable_options.label #81

Closed
pkarw opened this issue Jul 10, 2019 · 1 comment
Closed

Add support for configurable_options.label #81

pkarw opened this issue Jul 10, 2019 · 1 comment
Assignees
@afirlejczyk

Comments

@pkarw
Copy link
Contributor

pkarw commented Jul 10, 2019

Hi there! In mage2vuestorefront we're setting up the product.configurable_options.label by extrapolating the value_index to exact attribute label

https://github.com/DivanteLtd/mage2vuestorefront/blob/c71788e1c918225685344657f9d6ca0b2417d801/src/adapters/magento/product.js#L486

Can we apply this to magento-2-vsbridge indexer as well?
@afirlejczyk afirlejczyk self-assigned this Jul 10, 2019
@afirlejczyk
Copy link
Contributor

afirlejczyk commented Jul 10, 2019 •
edited
Loading

We have a label for configurable_options, but we don't have a label for configurable_options.values. ;)

afirlejczyk pushed a commit that referenced this issue Jul 10, 2019
Add support for configurable value label. #81
efda6e4
afirlejczyk pushed a commit that referenced this issue Jul 10, 2019
Add support for configurable value label. #81
1bf2d79
afirlejczyk added a commit that referenced this issue Jul 10, 2019
@afirlejczyk
Merge pull request #83 from DivanteLtd/feature/support-for-configurab…
6dc6e24 
…le-option-label

Add support for configurable value label. #81
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@afirlejczyk afirlejczyk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pkarw @afirlejczyk