Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: improve shiki twoslash options #350

Merged
merged 13 commits into from
Feb 16, 2025
Merged

perf: improve shiki twoslash options #350

merged 13 commits into from
Feb 16, 2025

Conversation

pengzhanbo
Copy link
Member

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Provide a description in this PR that addresses what the PR is solving. If this PR is going to solve an existing issue, please reference the issue (e.g. close #123).

What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Other

Description

Screenshots

Before

After

Copy link

netlify bot commented Feb 10, 2025

Deploy Preview for vuepress-ecosystem failed. Why did it fail? →

Name Link
🔨 Latest commit b6e3c4c
🔍 Latest deploy log https://app.netlify.com/sites/vuepress-ecosystem/deploys/67aa0d0d88611900082b352f

@coveralls
Copy link

coveralls commented Feb 10, 2025

Pull Request Test Coverage Report for Build 13259994264

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 59.628%

Changes Missing Coverage Covered Lines Changed/Added Lines %
plugins/markdown/plugin-shiki/src/node/markdown/highlighter/createShikiHighlighter.ts 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
plugins/markdown/plugin-shiki/src/node/markdown/highlighter/createShikiHighlighter.ts 3 69.05%
Totals Coverage Status
Change from base Build 13239558436: -0.03%
Covered Lines: 1348
Relevant Lines: 2043

💛 - Coveralls

@Mister-Hope Mister-Hope merged commit d5aa2e3 into main Feb 16, 2025
34 checks passed
@Mister-Hope Mister-Hope deleted the improve-twoslash branch February 16, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants