Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #823 #824

Closed
wants to merge 1 commit into from
Closed

fix: #823 #824

wants to merge 1 commit into from

Conversation

FistMeNaruto
Copy link
Contributor

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:
Before:
screenshot from 2018-09-11 23-36-17
After:
screenshot from 2018-09-11 23-35-46

Before:
screenshot from 2018-09-11 23-11-17
After:
screenshot from 2018-09-11 23-11-06

Before:
screenshot from 2018-09-11 23-42-47
After:
screenshot from 2018-09-11 23-54-03

Does this PR introduce a breaking change? (check one)

  • Yes
  • No (hopefully)

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox (long words do not break nav bar, but still introduce overflow-x; also word-break: break-word; does not work on Firefox, therefore menu links still oveflow, but overflow is hidden)
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Some information about the css properties used:
https://css-tricks.com/snippets/css/prevent-long-urls-from-breaking-out-of-container/

@ekoeryanto
Copy link
Contributor

I think we should use the specific tags selector instead of body

@FistMeNaruto
Copy link
Contributor Author

Generally I would agree with that, but in this case body targets both the content and menu. I don't see any case where long word breaking would introduce unwanted effects. But yes, specific tags can be used here aswell.

Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, but I don't think it should be added by default. users should be able to know when has his words been overlapped and there is almost no such long word in English.

@FistMeNaruto
Copy link
Contributor Author

I have brought this up mainly because I had an issue with a long URL in my own project (see first two pictures) and it introduced scroll overflow. I think it is relatively common to have URLs in text and it does make sense to break them in case they overflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants