Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show OutboundLink icon for external links #428

Merged
merged 4 commits into from
May 13, 2018

Conversation

ycmjason
Copy link
Contributor

@ycmjason ycmjason commented May 12, 2018

This PR includes the following enhancements

  • Replaced addAttr() by token.attrSet()
  • Show OutboundLink icon for external links in nav
  • Show OutboundLink icon for external links in markdown

@@ -1,23 +1,24 @@
<template>
<router-link
class="nav-link"
<router-link class="nav-link"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't format the original code

</template>

<script>
import { isExternal, isMailto, isTel, ensureExt } from './util'
import OutboundLink from './OutboundLink.vue'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you have registered <OutboundLink> as a global component, either that removing this import or removing the global registration. (You could only choose the 1st.)

@ycmjason
Copy link
Contributor Author

@ulivz done boss! please review again if you are free! 😄

Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants