Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate the timestamp of creation and last updated for each doc file (close #258) #282

Merged
merged 7 commits into from
May 3, 2018

Conversation

ulivz
Copy link
Member

@ulivz ulivz commented Apr 27, 2018

Close #258

@ulivz ulivz changed the title feat: generate the timestamp of creation and last updated feat: generate the timestamp of creation and last updated for each doc file Apr 27, 2018
@ulivz ulivz changed the title feat: generate the timestamp of creation and last updated for each doc file feat: generate the timestamp of creation and last updated for each doc file (close #258) Apr 27, 2018
@meteorlxy
Copy link
Member

meteorlxy commented Apr 27, 2018

When a file is saved without any changes, its mtimeMs will update, but git won't track the change. Will that cause some issue?

@ulivz
Copy link
Member Author

ulivz commented Apr 28, 2018

Good point, so there is a discussion which type of time should be provided to user.

@yyx990803
Copy link
Member

#258 (comment)

@ulivz
Copy link
Member Author

ulivz commented May 1, 2018

Updated to git commit time stamp.

@ulivz ulivz merged commit d9b290b into master May 3, 2018
@inosik
Copy link

inosik commented May 4, 2018

What if the project uses some other version control system? Or if the project is in its early stages and not under version control yet?

@meteorlxy
Copy link
Member

@inosik That's it!

@ycmjason
Copy link
Contributor

ycmjason commented May 4, 2018

@inosik Interesting thought, I think that's a valid point. Perhaps a fallback to fs would be a nice thing to have.

@meteorlxy
Copy link
Member

Yeah, I've ever thought about that but forgot to post to that issue.

If a new file is created, but has not been commited into git repo. Then if you are going to dev or build for test, it may cause some issue.

@ycmjason
Copy link
Contributor

ycmjason commented May 4, 2018

@meteorlxy @inosik
Should we create an issue so that we won't forget about this? 🌵

@yyx990803
Copy link
Member

Maybe the last updated feature should be off by default, and mention in docs that you need git to use this feature.

@ycmjason
Copy link
Contributor

ycmjason commented May 4, 2018

@yyx990803 that would be nice, since fs timestamp is not very informational anyways.

@inosik
Copy link

inosik commented May 4, 2018

Should we create an issue so that we won't forget about this?

See #340.

@ulivz
Copy link
Member Author

ulivz commented May 4, 2018

@yyx990803 fixed it at #338

@ulivz ulivz deleted the 258-support-last-updated-time branch May 9, 2018 17:26
@ulivz ulivz mentioned this pull request May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants