refactor: make the prepare process clearer and modify the resolve alias #277
Conversation
|
Review wanted~~~ |
|
@meteorlxy Code change looks good, but I need to take some time to run your code at my side, please wait for some time. |
|
@ulivz Hope to be merged ASAP~ I want to fix some issue or add some features based on this PR. |
| const outDir = siteConfig.dest | ||
| ? path.resolve(siteConfig.dest) | ||
| : path.resolve(sourceDir, '.vuepress/dist') | ||
|
|
||
| // resolve theme |
There was a problem hiding this comment.
move this section down? There are currently two // resolve theme blocks.
|
LGTM after the small change requested. |
|
@yyx990803 Tweaked, sir! |
There was a problem hiding this comment.
@yyx990803 I will merge this change and continue to develop for plugin API (#240).
@meteorlxy Thanks for the great work, and this change is very good, but before plugin API is stable, I hope we can avoid refactoring code on a large scale. or there will be many conflicts, thank you.
|
@meteorlxy Do you use slack or telegram? I can create a channel for that. |
|
Oh, I didn't use them before, but I can try them. Which one do you prefer? (How about Wechat first, LOL) |
|
@ulivz I tried slack, and my email is meteorlxy.cn@gmail.com |
|
@meteorlxy I have invited you to |
|
@ulivz sorry but I just saw this. Any chance I could join the slack or is this selected personell only? 😂😂😂 Wouldn't mind at all if not possible. 😁 |
|
@ycmjason sure, can you provide the email？Let me invite you. |
|
@ulivz me@ycmjason.com |
|
Could I also join the vuepress slack? It doesn't hurt to try asking 😂 I would like to follow along the Plugin API plans and future discussions... |
app.jsresolveOptionsprocess inprepareclearer@themealias to theme directory. Add@themeLayoutand@themeNotFoundaliases forLayout.vueandNotFound.vuerespectively.