Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat($theme-default): inform screen readers link opens in new tab/window (fix #2601) #2603

Conversation

d-pollard
Copy link
Collaborator

@d-pollard d-pollard commented Sep 9, 2020

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@d-pollard
Copy link
Collaborator Author

@ktquez - thanks for the review; added changes accordingly!

Copy link
Member

@bencodezen bencodezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great enhancement @d-pollard!

@bencodezen bencodezen merged commit 8d10119 into vuejs:master Sep 21, 2020
d-pollard added a commit to d-pollard/vuepress that referenced this pull request Sep 21, 2020
@khs1994
Copy link

khs1994 commented Oct 14, 2020

how to disable it?

khs1994 added a commit to docker-practice/docker_practice that referenced this pull request Oct 14, 2020
@ktquez
Copy link

ktquez commented Oct 14, 2020

@khs1994 Why?

Nothing changes visually.
I don't think it should be disabled.

But if you still want to modify this, you can replace the convert-router-link plugin.

@khs1994
Copy link

khs1994 commented Oct 14, 2020

my nav show (opens new window),how to hide it?

@ktquez
Copy link

ktquez commented Oct 14, 2020

@khs1994
#2650 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants