Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: watch for chokidar v3 #2436

Merged
merged 2 commits into from
Jun 9, 2020
Merged

Conversation

pikax
Copy link
Member

@pikax pikax commented Jun 9, 2020

Summary

Fix the watch files

What kind of change does this PR introduce? (check at least one)

  • Bugfixx

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Copy link
Member

@bencodezen bencodezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and verified. Thanks so much @pikax!

@bencodezen bencodezen merged commit 7e9d0c1 into vuejs:master Jun 9, 2020
@pikax pikax deleted the fix/watching_on_chokidar branch June 9, 2020 15:49
@ulivz
Copy link
Member

ulivz commented Jun 13, 2020

Thanks for this fix, this issue is actually introduced by this commit from anymatch, a dependency of chokidar.

BTW you should follow the conventional commit, or the changelog will not list this fix.

@ulivz ulivz mentioned this pull request Jun 13, 2020
18 tasks
larionov pushed a commit to larionov/vuepress that referenced this pull request Aug 19, 2020
* fix: watch for chokidar v3

* chore: remove comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants