Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix($default-theme): Fix deep sidebar links rendenring #1973

Merged
merged 2 commits into from
Oct 26, 2019

Conversation

kefranabg
Copy link
Collaborator

Summary

I realized deep sidebar links rendering was not working as expected.

Before fix:

Capture d’écran 2019-10-23 à 13 08 39

After fix:

Capture d’écran 2019-10-23 à 13 31 09

The sidebar links rendering code seems a bit complex, I'll try to refactor to make it more readable later.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@kefranabg kefranabg requested a review from ulivz October 23, 2019 11:38
@meteorlxy
Copy link
Member

Let's merge this PR first, as the sidebar of our docs has been broken for days. cc @ulivz

Looking forward to the further refactor @kefranabg ❤️

@meteorlxy meteorlxy merged commit 0e5519a into master Oct 26, 2019
@meteorlxy meteorlxy deleted the fix/deep-navbar-rendering branch October 26, 2019 04:15
@vue-bot
Copy link

vue-bot commented Oct 26, 2019

Hey @kefranabg, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants