fix($markdown): Fix four spaces codeblocks rendering (Closes #1921) #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyaillet
changed the title
kefranabg
changed the title
kefranabg
reviewed
Oct 17, 2019
| return `<!--beforebegin--><div class="language-${token.info.trim()} extra-class">` | ||
| + `<!--afterbegin-->${rawCode}<!--beforeend--></div><!--afterend-->` | ||
| } | ||
| const fence = md.renderer.rules.fence |
There was a problem hiding this comment.
Actually, I think you could make a small improvement :
const { fence, codeBlock } = md.renderer.rules
md.renderer.rules.fence = wrap(fence)
md.renderer.rules.code_block = wrap(codeBlock)
What do you think @pyaillet ?
There was a problem hiding this comment.
I need to rename codeBlock to code_block to do this.
And sadly, the linter doesn't like it:
vuepress/packages/@vuepress/markdown/lib/preWrapper.js
18:18 error Identifier 'code_block' is not in camel case camelcase
✖ 1 problem (1 error, 0 warnings)
There was a problem hiding this comment.
Oh sure, I missed that 😉
const { fence, code_block: codeBlock } = md.renderer.rules should work
|
Hey @pyaillet, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #1921
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: