Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix($shared-utils): Add curly quotes to rSpecial #1934

Merged
merged 1 commit into from
Oct 23, 2019
Merged

fix($shared-utils): Add curly quotes to rSpecial #1934

merged 1 commit into from
Oct 23, 2019

Conversation

verythorough
Copy link
Contributor

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

This adds to the list of characters that convert to - in links. If there are any sites with existing headings that contain those characters, their links will change, potentially resulting in broken links. On the other hand, links that include those characters can behave unpredictably, so they wouldn't have been perfectly working links to begin with.

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

[I checked the link id's in the built html source.]

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:
I noticed that #1619 and #1855 also include changes to this file. Feel free to wrap this into one of those!

Copy link
Collaborator

@kefranabg kefranabg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @verythorough 💪

@kefranabg kefranabg merged commit 28a0ed9 into vuejs:master Oct 23, 2019
@vue-bot
Copy link

vue-bot commented Oct 23, 2019

Hey @verythorough, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants