fix($core): Extract all headers tags instead of just h2, h3 #1904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kefranabg
changed the title
kefranabg
changed the title
|
I have the same problem, but I think the headers are more suitable from the vuepress configuration. If not configured, the default is [h2,h3]. |
|
Yep, I just noticed that there was already an opened PR to handle this. The good news with this PR is that this can be configured by the user. This makes this PR obsolete I guess |
|
I'm closing this PR in favor of #1730 that will fix the issue in a better way. |
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #1903
Currently, the headers are hardcoded to only include h2 and h3, this makes it hard/impossible to access any other non h2/h3 headers.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)