Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tip after the server has started #130

Merged
merged 2 commits into from
Apr 18, 2018
Merged

Conversation

wangyi7099
Copy link
Contributor

No description provided.

lib/dev.js Outdated
@@ -82,7 +82,7 @@ module.exports = async function dev (sourceDir, cliOptions = {}) {
isFirst = false
console.log(
`\n VuePress dev server listening at ${
chalk.cyan(`http://localhost:${port}${options.publicPath}`)
chalk.cyan(`http://${cliOptions.host || options.siteConfig.host || '0.0.0.0'}:${port}${options.publicPath}`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why setting the fallback to '0.0.0.0' instead of 'localhost'?

Copy link
Contributor Author

@wangyi7099 wangyi7099 Apr 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ulivz

Because I see the following host setting of the context fallback to 0.0.0.0

@yyx990803 yyx990803 merged commit fd447ae into vuejs:master Apr 18, 2018
@wangyi7099 wangyi7099 deleted the patch-2 branch April 20, 2018 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants