Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

external url can use in sidebar and nav bar but it's broken at bottom nav bar(prev ,next) #1962

Closed
uwings opened this issue Oct 17, 2019 · 7 comments · Fixed by #1984 · May be fixed by adamlaska/osmos-cosmos-sdk#5
Closed
Labels
contribution welcome Contributions welcome has PR Has a related PR type: feature request Request to add a new feature

Comments

@uwings
Copy link

uwings commented Oct 17, 2019

external url can use in sidebar and nav bar , I mean , if support external in sidebar and bav bar why can't support at page nav? is there a conflict?

@haoranpb
Copy link
Contributor

I can work on this if it is expected

@kefranabg
Copy link
Collaborator

@uwings prev and next links are meant to target (as their name indicates) a previous or next link in the sidebar. Allowing them to target external url would be strange in my opinion.

If you need to target an external url in your page, use custom vue components in your markdown or theme inheritance to custom the default-theme.

@uwings
Copy link
Author

uwings commented Oct 20, 2019

@kefranabg yes , u can have u own opinion , but vuepress support external links in sidebar . so is this an conflict? in my opinion u can fix sidebar (cancel support external link), or fix bottom navbar (support external link), what do u think ?

@kefranabg kefranabg reopened this Oct 20, 2019
@uwings
Copy link
Author

uwings commented Oct 21, 2019

by the way , prev-next-links can resolve the issue , for now .

@Mister-Hope
Copy link
Contributor

Mister-Hope commented Oct 25, 2019

Yes, tried, same opinion with author, I have external links in sidebar too

@kefranabg
Copy link
Collaborator

kefranabg commented Oct 26, 2019

@uwings I didn't know that external links were supported by sidebar, in that case supporting external links for prev/next make sense 😉

@kefranabg kefranabg added the has PR Has a related PR label Oct 27, 2019
@uwings
Copy link
Author

uwings commented Nov 5, 2019

@kefranabg @ludanxer thank you guys very much .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution welcome Contributions welcome has PR Has a related PR type: feature request Request to add a new feature
Projects
None yet
4 participants