docs: use ssrPrefetch in data guide #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atinux
reviewed
Dec 6, 2018
docs/guide/data.md
Outdated
| }, | ||
|
|
||
| mounted () { | ||
| this.fooInc() |
There was a problem hiding this comment.
Why not checking here also if this.fooCount is not set @Akryum ?
There was a problem hiding this comment.
Fixed, and more improvements ✔️
yyx990803
requested changes
Dec 20, 2018
| store.replaceState(window.__INITIAL_STATE__) | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Not sure if it's a good idea removing the whole client data-fetching part here, as they still address some problems that are not completely solved by ssrPrefetch, e.g. triggering fetches on route change.
There was a problem hiding this comment.
There was a problem hiding this comment.
But this data-prefetching part is still outdated, because it can't prefetch non-route components.
There was a problem hiding this comment.
Yeah, I mean we need something to replace it
yyx990803
added a commit
that referenced
this pull request
Feb 4, 2019
* 2.6: serverCacheKey bail out * 2.6: api additions * docs: use ssrPrefetch in data guide (#214) * 2.6: serverPrefetch updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked the data prefetching guide to use
ssrPrefetchand removed all the now unnecessary boilerplate code.Related feature PR in core: vuejs/vue#9017