Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to fix #6353 #6522

Closed
wants to merge 7 commits into from
Closed

try to fix #6353 #6522

wants to merge 7 commits into from

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Sep 6, 2017

defineProperty styles in vue-server-renderer

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
See also: vuejs/vue-style-loader#7

fix #6353

@defcc
Copy link
Member

defcc commented Sep 6, 2017

I updated the content to automatically refer the related issue.

@yyx990803
Copy link
Member

Thanks for the PR! However, this change requires vue-style-loader to be updated simultaneously, and this can lead to subtle problems if the user only updated vue core. I managed to find a fix that doesn't need vue-style-loader update in 1f52a2a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SSR] context.styles is undefined when runInNewContext !== true
3 participants