Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mixin provide with Symbols don't get merged properly #7923

Closed
privatenumber opened this issue Mar 29, 2018 · 2 comments
Closed

Mixin provide with Symbols don't get merged properly #7923

privatenumber opened this issue Mar 29, 2018 · 2 comments
Labels
has PR improvement

Comments

@privatenumber
Copy link
Contributor

Version

2.5.16

Reproduction link

https://jsfiddle.net/hirokiosame/38nzxq6c/26/

Steps to reproduce

Run the code. The injected result will show [undefined, "bar"] in the console.

What is expected?

For the merging to work properly. The expected result is ['foo', 'bar'], which is what you'll see when you convert keyA and keyB into strings.

What is actually happening?

Merging fails: [undefined, "bar"]
privatenumber pushed a commit to privatenumber/vue that referenced this issue Mar 29, 2018
fix(provide): Merges symbol provides
e392ec3 
Fixes merging multiple provides using Symbols

fix vuejs#7923
@privatenumber privatenumber mentioned this issue Mar 29, 2018
Merged
13 tasks
@privatenumber
Copy link
Contributor Author

@posva Would you mind taking a look at this?

@vuejs vuejs deleted a comment from jennivey2009 Apr 26, 2018
@yyx990803
Copy link
Member

Closed via #7926

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
has PR improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@yyx990803 @posva @privatenumber @haoqunjiang