fix: function names #580
Merged
fix: function names #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyerburgh
reviewed
May 4, 2018
| } | ||
| } | ||
|
|
||
| function addSlotToVm (vm: Component, slotName: string, slotValue: Component | string | Array<Component> | Array<string>): void { |
There was a problem hiding this comment.
Could you move the slotValue into its own type:
type SlotValue = Component | string | Array<Component> | Array<string>
There was a problem hiding this comment.
Thank you for pointng out.
I added a type.
|
I think a person who do not understand specifications and codes can not add large cosmetic change appropriately. |
|
I've skipped the failing tests—#581 |
38elements
commented
May 5, 2018
| if (typeof slotValue === 'string') { | ||
| slotValue = slotValue.trim() |
There was a problem hiding this comment.
When slotValue is ' foo ', this line make a bug.
This process introduced at #556 .
I added a test for spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this make it easy to read and
git blame.