Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapper array consistency #1650

Merged
merged 6 commits into from
Aug 19, 2020
Merged

Conversation

AtofStryker
Copy link
Contributor

Currently, the wrapper-array and wrapper API's are a bit diverged. The standalone wrapper is awaitable, but the wrapper-array is not currently, which means other means of promise settling are needed to make sure the components are updated in wrapper-array. This PR allows for those wrapper-array items to be awaited and consistent with the wrapper API.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe: Documentation Update

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Make wrapperarray setData awaitable to be consistent with wrapper setData
Make wrapperarray setProps awaitable to be consistent with wrapper setData
Make wrapperarray setValue awaitable to be consistent with wrapper setValue
Make wrapperarray setChecked awaitable to be consistent with wrapper setChecked
Make wrapperarray trigger awaitable to be consistent with wrapper trigger
@AtofStryker AtofStryker mentioned this pull request Aug 18, 2020
13 tasks
@AtofStryker AtofStryker marked this pull request as ready for review August 18, 2020 04:50
@lmiller1990
Copy link
Member

Makes sense.

@lmiller1990 lmiller1990 merged commit 8cc6654 into vuejs:dev Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants