Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use push instead of replace in ensureURL #894

Merged
merged 2 commits into from
Nov 14, 2016
Merged

use push instead of replace in ensureURL #894

merged 2 commits into from
Nov 14, 2016

Conversation

vvenv
Copy link

@vvenv vvenv commented Nov 10, 2016

Fixes #887

@fnlctrl
Copy link
Member

fnlctrl commented Nov 11, 2016

Hmm, using pushState/pushHash is a valid fix for the scenario in #887, though it shouldn't be done in ensureUrl, instead they should only be triggered after next(false) is called, here: https://github.com/vuejs/vue-router/blob/dev/src/history/base.js#L70-L72.
Would you mind fixing it? Should probably add a parameter to ensureURL to decide whether to call replace or push.

/ping @posva @LinusBorg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants