Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: typo in node.js example #3205

Merged
merged 3 commits into from
May 20, 2020
Merged

docs: typo in node.js example #3205

merged 3 commits into from
May 20, 2020

Conversation

Steven-Chang1114
Copy link
Contributor

It appears in https://router.vuejs.org/guide/essentials/history-mode.html#example-server-configurations as the index.html is mistyped as index.htm in the Native Node.js section

posva
posva requested changes May 20, 2020
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can you remove the package-lock file please?

@Steven-Chang1114
Copy link
Contributor Author

Thanks, can you remove the package-lock file please?

Of course! was wondering why it falis the deployment check.

posva
posva approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@posva posva changed the title Docs: Fix the typo in Node.js exmaple code in HTML5 History Mode documentation docs: typo in node.js example May 20, 2020
@posva posva merged commit 231f4a5 into vuejs:dev May 20, 2020
@Steven-Chang1114
Copy link
Contributor Author

Cheers, thank you for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Steven-Chang1114 @posva