Fix "#" placed incorrectly when query string is present on load (#2125) #2253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s#2125) When navigating to a URL with a query string like myapp.com?foo=bar in hash mode, the hash is currently placed after the query string myapp.com?foo=bar#/ This fix correctly parses URLs with query strings so that the above URL will be myapp.com/#/?foo=bar after loading.
posva
requested changes
Jun 11, 2018
|
@posva thanks for the quick review. I noticed the behavior you're describing when navigating routes, but I wasn't sure what the desired behavior should be. Thanks for clearing that up. |
|
I've submitted a PR #2262 which addresses this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When navigating to a URL with a query string like
myapp.com?foo=barin hash mode, the hash is currently placed after the query stringmyapp.com?foo=bar#/This fix correctly parses URLs with query strings so that the above URL will be
myapp.com/#/?foo=barafter loading.