Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accurate typings for Routeconfig: component, components, props #3217

Closed
javiertury opened this issue Jun 2, 2020 · 0 comments · Fixed by #3218
Closed

Accurate typings for Routeconfig: component, components, props #3217

javiertury opened this issue Jun 2, 2020 · 0 comments · Fixed by #3218
Labels
Typescript Typescript related issues

Comments

@javiertury
Copy link
Contributor

What problem does this feature solve?

The typings have the following problems

  • A configuration can have both component and components
  • When multiple named components are used, props should be a Dictionary of the regular props typings. Right now it doesn't complain because Object is among the regular props typings, however it cannot infer the accurate typing of each of the props, it just uses any.

What does the proposed API look like?

There is no API
javiertury added a commit to javiertury/vue-router that referenced this issue Jun 2, 2020
@javiertury
feat(types): RouterConfig for multiple components (vuejs#3217)
645a870
@javiertury javiertury mentioned this issue Jun 2, 2020
Merged
@posva posva added the Typescript Typescript related issues label Jun 3, 2020
javiertury added a commit to javiertury/vue-router that referenced this issue Jun 3, 2020
@javiertury
feat(types): RouterConfig for multiple components (vuejs#3217)
a9052ec
javiertury added a commit to javiertury/vue-router that referenced this issue Jun 3, 2020
@javiertury
feat(types): RouterConfig for multiple components (vuejs#3217)
6d3cb0b
javiertury added a commit to javiertury/vue-router that referenced this issue Jun 3, 2020
@javiertury
feat(types): RouterConfig for multiple components (vuejs#3217)
e462bb2
javiertury added a commit to javiertury/vue-router that referenced this issue Jun 3, 2020
@javiertury
feat(types): RouterConfig for multiple components (vuejs#3217)
9a3349f
posva added a commit that referenced this issue Jun 4, 2020
@javiertury @posva
feat(types): RouterConfig for multiple components (#3217) (#3218)
dab86c5 
* feat(types): RouterConfig for multiple components (#3217)

* Apply suggestions from code review

Co-authored-by: Eduardo San Martin Morote <posva@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Typescript Typescript related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(types): RouterConfig for multiple components (#3217) javiertury/vue-router
2 participants
@posva @javiertury