Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vue-router 2.1.2 has broken in IE 9 #1104

Closed
ttionya opened this issue Jan 19, 2017 · 0 comments
Closed

vue-router 2.1.2 has broken in IE 9 #1104

ttionya opened this issue Jan 19, 2017 · 0 comments

Comments

@ttionya
Copy link

ttionya commented Jan 19, 2017

Vue.js / vue-router versions

2.1.10 / 2.1.2

Steps to reproduce

In IE 9 (IE 11 with document mode 9), there are two error in console. One is vue, another is vue-router.

About vue-router, console show Object doesn't support this property or method (now).

对象不支持“now”属性或方法

What is actually happening?

I have checkout the vue-router source code, and find the problem.

1961d35#diff-6f3e0f40e05988a09d760ec1a86f3420

On line 17, inBrowser is true, but window.performance does not have now method in IE 9.

It is a mistake.

posva added a commit that referenced this issue Jan 19, 2017
Fix #1104

IE 9 supports the performance API but doesn't have the now method. Since we're relying specifically on that one, better directly check for performance.now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants