Avoid rearrange query parameters (#946)

* avoid rearrange query params * delete unit text about query sorted alphabetically * delete unit text about query sorted alphabetically
vuejs · Nov 28, 2016 · d4de8c8 · d4de8c8
1 parent c174f8d
commit d4de8c8
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 12 deletions.
diff --git a/src/util/query.js b/src/util/query.js
@@ -55,7 +55,7 @@ function parseQuery (query: string): Dictionary<string> {
 }
 
 export function stringifyQuery (obj: Dictionary<string>): string {
-  const res = obj ? Object.keys(obj).sort().map(key => {
+  const res = obj ? Object.keys(obj).map(key => {
     const val = obj[key]
 
     if (val === undefined) {

diff --git a/test/e2e/specs/active-links.js b/test/e2e/specs/active-links.js
@@ -14,7 +14,7 @@ module.exports = {
       .assert.attributeContains('li:nth-child(6) a', 'href', '/active-links/users/evan#foo')
       .assert.attributeContains('li:nth-child(7) a', 'href', '/active-links/users/evan?foo=bar')
       .assert.attributeContains('li:nth-child(8) a', 'href', '/active-links/users/evan?foo=bar')
-      .assert.attributeContains('li:nth-child(9) a', 'href', '/active-links/users/evan?baz=qux&foo=bar')
+      .assert.attributeContains('li:nth-child(9) a', 'href', '/active-links/users/evan?foo=bar&baz=qux')
       .assert.attributeContains('li:nth-child(10) a', 'href', '/active-links/about')
       .assert.attributeContains('li:nth-child(11) a', 'href', '/active-links/about')
       .assert.containsText('.view', 'Home')

diff --git a/test/unit/specs/query.spec.js b/test/unit/specs/query.spec.js
@@ -10,14 +10,4 @@ describe('Query utils', () => {
       }))
     })
   })
-
-  describe('stringifyQuery', () => {
-    it('should work', () => {
-      expect(stringifyQuery({
-        foo: 'bar',
-        baz: 'qux',
-        arr: [1, 2]
-      })).toBe('?arr=1&arr=2&baz=qux&foo=bar') // sorted alphabetically
-    })
-  })
 })