Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ts-jest dependency #284

Merged
merged 5 commits into from
Mar 6, 2021
Merged

Remove ts-jest dependency #284

merged 5 commits into from
Mar 6, 2021

Conversation

lmiller1990
Copy link
Member

No description provided.

@nogic1008
Copy link
Collaborator

@lmiller1990
Could you add yarn lock files into .gitignore ?
like this

/e2e/**/yarn.lock

@nogic1008 nogic1008 mentioned this pull request Sep 18, 2020
Merged
@lmiller1990
Copy link
Member Author

Hm, can we just move to yarn from npm? I find it way more stable, faster, and better in every way. Any reason to stay with npm?

@lmiller1990
Copy link
Member Author

@sodatea can you double check this is the change you asked for regarding the ts-jest dependency? Then I can do a release.

@nogic1008
Copy link
Collaborator

@lmiller1990

Hm, can we just move to yarn from npm? I find it way more stable, faster, and better in every way. Any reason to stay with npm?

I have no intention of returning from yarn to npm.
yarn.lock files in e2e folder are regenerated for each test, so it should be gitignored.

@lmiller1990
Copy link
Member Author

Right, yes, ok.

haoqunjiang
haoqunjiang approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@haoqunjiang haoqunjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍

@jobegrabber jobegrabber mentioned this pull request Oct 28, 2020
Closed
@nogic1008 nogic1008 mentioned this pull request Nov 4, 2020
Closed
@haoqunjiang
Copy link
Member

@lmiller1990 any chance this gets merged? The ts-jest dependency is causing really annoying peer dependency warnings in non-ts projects.

@lmiller1990
Copy link
Member Author

Oops @sodatea I forgot this. I rebased and resolved the conflicts. This will be released as 4.0.1 within 48h.

@lmiller1990 lmiller1990 merged commit 95784e4 into master Mar 6, 2021
@lmiller1990 lmiller1990 deleted the remove-ts-jest branch March 6, 2021 05:02
@lmiller1990
Copy link
Member Author

@sodatea it's out: https://github.com/vuejs/vue-jest/releases/tag/v4.0.1

Let me know if you have any other problems. Thanks!

@dependabot dependabot bot mentioned this pull request Mar 17, 2021
Merged
nogic1008 added a commit to nogic1008/vue-jest that referenced this pull request Mar 29, 2021
@nogic1008
chore: update test run script (Port from vuejs#284)
4e9dc59
nogic1008 added a commit that referenced this pull request Mar 29, 2021
@nogic1008
ci: setup GitHub Actions to next branch (#326)
acab463 
* ci: enable GitHub Actions (Port from #278)
* chore: update test run script (Port from #284)
* chore: remove yarn lock file
* chore(deps): bump e2e projects deps version
* chore: hoist package dependencies
@renovate renovate bot mentioned this pull request May 22, 2021
Closed
1 task
This was referenced Jun 6, 2021
Closed
Closed
Closed
@Silverium Silverium mentioned this pull request Jan 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haoqunjiang haoqunjiang haoqunjiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lmiller1990 @nogic1008 @haoqunjiang