fix(ts-config): remove dependency on ts-jest and configure tsconfif w… #161
Conversation
|
Thanks for this :) The link you've posted is 404ing. Is it a private repo? |
lib/utils.js
Outdated
| @@ -1,6 +1,8 @@ | |||
| const loadPartialConfig = require('@babel/core').loadPartialConfig | |||
| const createTransformer = require('ts-jest').createTransformer | |||
There was a problem hiding this comment.
This will still error if users don't have TypeScript installed, can you move the require to inside the getTSConfig function
e2e/__projects__/tsconfig/test.js
Outdated
| @@ -0,0 +1,54 @@ | |||
| import { getTSConfig } from 'vue-jest/lib/utils' | |||
There was a problem hiding this comment.
This directory is intended for e2e tests
|
Thanks for the work :) I think it's fine to use Babel for TypeScript:
I thought we could use babel in the beta version and get feedback from users. FYI The reason we started to use ts-jest originally was to move the logic for resolving tsconfig options to another package. But I'm not sure the package is going to be maintained, so we should remove it as a dependency. Can you open a new PR that uses babel for compiling TypeScript? |
yohodopo
force-pushed
the
fix/ts-config
branch
2 times, most recently
from
21e31cd to
ea45492
Compare
yohodopo
force-pushed
the
fix/ts-config
branch
from
ea45492 to
ad428a0
Compare
|
We fixed this in another PR. |
…ith vue-jest
Remove dependency over ts-jest and let the user configure his tsconfig with
vue-jestwhen specified.When tsconfig/ts-jest is not configured then a will look for tsconfig at the root of the application.
Hey @eddyerburgh I've tried creating to use babel to compile typescript files here https://github.com/yohodopo/vuejest/blob/bcfa5bc337910f0ba86a93c42d660a5c2bfa74f7/lib/utils.js#L112-L131 but I'm not very confident if thats what we'd want to do that since users might want to use some of the features it does not offer yet with the list of plugins, It would also take away the most desired feature of typechecking.