Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Section about deprecated onDemand and onAbort callback arguments #2330

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

DangerousDetlef
Copy link
Contributor

The onDemand and onAbort callback arguments for router.push and .replace were deprecated in v4. I added a section to the migration guide explaining that users should replace them with the thenable Promise the methods return.

… guide

The  onDemand and onAbort  callbacks for router.push and .replace were deprecated in v4. I added a section to the migration guide explaining that users should replace them with the thenable Promise the methods return.
Copy link

netlify bot commented Aug 5, 2024

Deploy Preview for vue-router ready!

Name Link
🔨 Latest commit 34f5de8
🔍 Latest deploy log https://app.netlify.com/sites/vue-router/deploys/66b1c25ce3832a000825c91c
😎 Deploy Preview https://deploy-preview-2330--vue-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

packages/docs/guide/migration/index.md Outdated Show resolved Hide resolved
packages/docs/guide/migration/index.md Outdated Show resolved Hide resolved
packages/docs/guide/migration/index.md Outdated Show resolved Hide resolved
@posva posva merged commit 9f95fb7 into vuejs:main Aug 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants