Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: style error caused by banner #2099

Merged
merged 2 commits into from
Jan 3, 2024
Merged

docs: style error caused by banner #2099

merged 2 commits into from
Jan 3, 2024

Conversation

heygsc
Copy link
Contributor

@heygsc heygsc commented Jan 3, 2024

fix: #2096

It seems that " --vt-banner-height " is not used in class " aside-container ".
And " --vp-layout-top-height " has no value in here, so I set it.

Copy link

netlify bot commented Jan 3, 2024

Deploy Preview for vue-router ready!

Name Link
🔨 Latest commit d8dbe04
🔍 Latest deploy log https://app.netlify.com/sites/vue-router/deploys/6595220d1f894c000802a47d
😎 Deploy Preview https://deploy-preview-2099--vue-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Turns out the other variable does not exist anymore

@posva
Copy link
Member

posva commented Jan 3, 2024

@i5dr0id This is Worth noting for future banner updates on vitepress sites

@posva posva merged commit eff7ec0 into vuejs:main Jan 3, 2024
4 checks passed
niceplugin added a commit to niceplugin/Vuejs-Router-KO that referenced this pull request Jan 15, 2024
niceplugin added a commit to niceplugin/Vuejs-Router-KO that referenced this pull request Jan 15, 2024
* docs: style error caused by banner (vuejs#2099)

* docs: support dir in meta for pages (vuejs#2085)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs style error
2 participants