Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show view size while dragging split pane #253

Merged
merged 6 commits into from
Jun 4, 2024

Conversation

btea
Copy link
Contributor

@btea btea commented Jun 1, 2024

When dragging a view, the size of the view area is displayed in real time, without the need to confirm through developer tools.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link

vercel bot commented Jun 1, 2024

@btea is attempting to deploy a commit to the vuejs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jun 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
repl ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2024 3:15pm

src/SplitPane.vue Outdated Show resolved Hide resolved
@sxzz
Copy link
Member

sxzz commented Jun 1, 2024

The displayed height does not match the iframe's height. We should exclude the output tab.

@btea
Copy link
Contributor Author

btea commented Jun 2, 2024

Oh, sorry, I forgot about that.

src/SplitPane.vue Outdated Show resolved Hide resolved
src/SplitPane.vue Outdated Show resolved Hide resolved
src/SplitPane.vue Outdated Show resolved Hide resolved
@sxzz sxzz merged commit a6bbeea into vuejs:main Jun 4, 2024
1 check failed
@sxzz sxzz changed the title feat: dragging view area show view size feat: show view size while dragging split pane Jun 4, 2024
@btea btea deleted the feat/dragging-view-show-view-size branch June 4, 2024 05:47
src/SplitPane.vue Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants