-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support raw Vue SSR #90
Conversation
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 5 +1
Lines 90 112 +22
Branches 14 19 +5
=========================================
+ Hits 90 112 +22
Continue to review full report at Codecov.
|
@posva I can get back to the MR next week to resolve the codecov issues. Would you accept setting thresholds in jest.config.js to get faster feedback on coverage? |
…refetch option merge
Thank you for this! I haven’t had the time yet to check it but I will try to this week or next week |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this! There are a few minor things to change and other style-related changes I will change locally after merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
I did not set up a Nuxt app yet, but tested with a basic Vue SSR application. I'm happy to double-check if the Nuxt Plugin still works in case the PR looks good otherwise :)