Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract component feature #1707

Closed
wants to merge 3 commits into from
Closed

Conversation

IIFelix
Copy link
Collaborator

@IIFelix IIFelix commented Aug 11, 2022

Add new command for extracting selected text into new component.
Also add new docs entry.

Add new command for extracting selected text into new component.
@IIFelix IIFelix requested a review from johnsoncodehk August 11, 2022 08:09
@IIFelix IIFelix added the enhancement New feature or request label Aug 11, 2022
@johnsoncodehk
Copy link
Member

Thanks! I also have to investigate how to implement auto import component after extracted.

@johnsoncodehk
Copy link
Member

After a long consideration, I decided not to add this feature for the following reasons. 🙏

  • Extract component feature is not suitable for everyone. Some people may expect to only extract the template without making any script changes; some may expect to refactor the used properties into props at the same time.
  • For implement props extraction, language server needs to add a new request API, and I want to avoid language server scope bigger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants