Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(no-ref-as-operand): use ref.value to replace ref when emit #2680

Merged
merged 8 commits into from
Feb 20, 2025
Merged

feat(no-ref-as-operand): use ref.value to replace ref when emit #2680

merged 8 commits into from
Feb 20, 2025

Conversation

chouchouji
Copy link
Contributor

@chouchouji chouchouji commented Feb 10, 2025 •
edited
Loading

Issue

close #2601

@chouchouji chouchouji changed the title feat(no-ref-as-operand): use value of ref to replace ref when emit feat(no-ref-as-operand): use ref.value to replace ref when emit Feb 10, 2025
FloEdelmann
FloEdelmann requested changes Feb 14, 2025
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I now had a deeper look and apart from a few code maintenance/readbility improvements, it looks good to me 🙂

@chouchouji
Copy link
Contributor Author

Thanks for your contribution! I now had a deeper look and apart from a few code maintenance/readbility improvements, it looks good to me 🙂

Thanks for your reply! I had updated code.

FloEdelmann
FloEdelmann approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing the feedback so quickly! LGTM now.

@chouchouji
Copy link
Contributor Author

Thanks for implementing the feedback so quickly! LGTM now.

Thanks!

waynzh
waynzh approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@waynzh waynzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@waynzh waynzh merged commit af3700f into vuejs:master Feb 20, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann approved these changes

@waynzh waynzh waynzh approved these changes

@ota-meshi ota-meshi Awaiting requested review from ota-meshi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule proposal: no-ref-emit
3 participants
@chouchouji @FloEdelmann @waynzh