Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignoreProps option to vue/prop-name-casing #2679

Merged
merged 7 commits into from
Feb 20, 2025

Conversation

westberliner
Copy link
Contributor

Hi,

is this something you would be interested in - at least I did 😄 ?
If yes I would extend the test for it as well. If not then close it.

Thx
Patrick

@waynzh
Copy link
Member

waynzh commented Feb 10, 2025

That makes sense to me. You can continue to add test cases and documentation when you have time.
For reference, you might find similar ones in vue/custom-event-name-casing if you need it.

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a good addition to the rule! I have a few comments though. Like @waynzh already said, please also add tests and documentation.

@westberliner
Copy link
Contributor Author

Fixed everything as we talked about.

Copy link
Member

@waynzh waynzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

westberliner and others added 2 commits February 20, 2025 09:01
Co-authored-by: Wayne Zhang <waynzh19@gmail.com>
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from one syntax error in the docs' example code, this looks good to me 🙂

@FloEdelmann FloEdelmann changed the title extend prop-name-casing to ignore specific names Add ignoreProps option to vue/prop-name-casing Feb 20, 2025
@FloEdelmann FloEdelmann merged commit 14450d2 into vuejs:master Feb 20, 2025
12 checks passed
@westberliner westberliner deleted the patch-2 branch February 20, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants