-
-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add globals
option to component-name-in-template-casing
#1989
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The option looks good to me. But I have a few requests.
Co-authored-by: Flo Edelmann <florian-edelmann@online.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR! The rule implementation looks good! Could you please add a example code to the docs where we can try out the new option?
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I've thought a little more about this problem. Consider this: // main.js
Vue.component('SomeComp', ...)
// App.js
export default {
components: { 'some-comp': ... },
template: '<SomeComp />'
} It works fine in that
So the current logic is fine. |
globals
option to component-name-in-template-casing
globals
option to component-name-in-template-casing
Currently the
component-name-in-template-casing
can't check globally registered components. This PR adds an option to explicitly list global components to check.