-
-
Notifications
You must be signed in to change notification settings - Fork 669
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
New: add no-use-computed-property-like-method rules (#1234)
* chore: init rule * feat: getable methodProperties * feat: move getMethodProperties into util * feat: pass rule * feat: remove getMethodProperties * docs: add docs * chore: run update * feat: check return type of data props methods computed * feat: add types to eslint utils getStaticValue * feat: refactor rule * docs: fix docs * docs: fix docs * feat: change report node * chore: remove unused file * refactor: improve JSDoc * docs: remove template * docs: fix docs * docs: fix docs * feat: change target node * feat: rename getComponentPropsType * rename eslint * refactor: rename PropertyMap * refactor: improve if statement * Revert "refactor: improve if statement" This reverts commit 8b825e5. * feat: consider basic props type * chore: run update * refactor improve selector * feat: addPropertyMap * refactor: use findProperty * refactor: add comment * feat: cover ThisExpression * feat: support return statement return nothing * fix: support undefined of propertyMap[thisMember] * style: run lint * test: add test case
- Loading branch information
1 parent
8c3031e
commit 9856621
Showing
7 changed files
with
1,310 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,340 @@ | ||
| --- | ||
| pageClass: rule-details | ||
| sidebarDepth: 0 | ||
| title: vue/no-use-computed-property-like-method | ||
| description: disallow use computed property like method | ||
| --- | ||
| # vue/no-use-computed-property-like-method | ||
|
|
||
| > disallow use computed property like method | ||
| - :exclamation: <badge text="This rule has not been released yet." vertical="middle" type="error"> ***This rule has not been released yet.*** </badge> | ||
|
|
||
| ## :book: Rule Details | ||
|
|
||
| This rule disallows to use computed property like method. | ||
|
|
||
| <eslint-code-block :rules="{'vue/no-use-computed-property-like-method': ['error']}"> | ||
|
|
||
| ```vue | ||
| <script> | ||
| export default { | ||
| data() { | ||
| return { | ||
| dataString: 'dataString', | ||
| dataNumber: 10, | ||
| dataObject: { | ||
| inside: 'inside' | ||
| }, | ||
| dataArray: [1, 2, 3, 4, 5], | ||
| dataBoolean: true, | ||
| dataFunction() { | ||
| alert('dataFunction') | ||
| } | ||
| } | ||
| }, | ||
| props: { | ||
| propsString: String, | ||
| propsNumber: Number, | ||
| propsObject: Object, | ||
| propsArray: Array, | ||
| propsBoolean: Boolean, | ||
| propsFunction: Function, | ||
| objectPropsString: { | ||
| type: String | ||
| }, | ||
| objectPropsNumber: { | ||
| type: Number | ||
| }, | ||
| objectPropsObject: { | ||
| type: Object | ||
| }, | ||
| objectPropsArray: { | ||
| type: Array | ||
| }, | ||
| objectPropsBoolean: { | ||
| type: Boolean | ||
| }, | ||
| objectPropsFunction: { | ||
| type: Function | ||
| } | ||
| }, | ||
| computed: { | ||
| computedReturnDataString() { | ||
| return this.dataString | ||
| }, | ||
| computedReturnDataNumber() { | ||
| return this.dataNumber | ||
| }, | ||
| computedReturnDataObject() { | ||
| return this.dataObject | ||
| }, | ||
| computedReturnDataArray() { | ||
| return this.dataArray | ||
| }, | ||
| computedReturnDataBoolean() { | ||
| return this.dataBoolean | ||
| }, | ||
| computedReturnDataFunction() { | ||
| return this.dataFunction | ||
| }, | ||
| computedReturnPropsString() { | ||
| return this.propsString | ||
| }, | ||
| computedReturnPropsNumber() { | ||
| return this.propsNumber | ||
| }, | ||
| computedReturnPropsObject() { | ||
| return this.propsObject | ||
| }, | ||
| computedReturnPropsArray() { | ||
| return this.propsArray | ||
| }, | ||
| computedReturnPropsBoolean() { | ||
| return this.propsBoolean | ||
| }, | ||
| computedReturnPropsFunction() { | ||
| return this.propsFunction | ||
| }, | ||
| computedReturnObjectPropsString() { | ||
| return this.objectPropsString | ||
| }, | ||
| computedReturnObjectPropsNumber() { | ||
| return this.objectPropsNumber | ||
| }, | ||
| computedReturnObjectPropsObject() { | ||
| return this.objectPropsObject | ||
| }, | ||
| computedReturnObjectPropsArray() { | ||
| return this.objectPropsArray | ||
| }, | ||
| computedReturnObjectPropsBoolean() { | ||
| return this.objectPropsBoolean | ||
| }, | ||
| computedReturnObjectPropsFunction() { | ||
| return this.objectPropsFunction | ||
| }, | ||
| computedReturnString() { | ||
| return 'computedReturnString' | ||
| }, | ||
| computedReturnNumber() { | ||
| return 10 | ||
| }, | ||
| computedReturnObject() { | ||
| return { | ||
| inside: 'inside' | ||
| } | ||
| }, | ||
| computedReturnArray() { | ||
| return [1, 2, 3, 4, 5] | ||
| }, | ||
| computedReturnBoolean() { | ||
| return true | ||
| }, | ||
| computedReturnFunction() { | ||
| const fn = () => alert('computedReturnFunction') | ||
| return fn | ||
| }, | ||
| computedReturnMethodsReturnString() { | ||
| return this.methodsReturnString | ||
| }, | ||
| computedReturnMethodsReturnNumber() { | ||
| return this.methodsReturnNumber | ||
| }, | ||
| computedReturnMethodsReturnObject() { | ||
| return this.methodsReturnObject | ||
| }, | ||
| computedReturnMethodsReturnArray() { | ||
| return this.methodsReturnArray | ||
| }, | ||
| computedReturnMethodsReturnBoolean() { | ||
| return this.methodsReturnBoolean | ||
| }, | ||
| computedReturnMethodsReturnFunction() { | ||
| return this.methodsReturnFunction | ||
| } | ||
| }, | ||
| methods: { | ||
| methodsReturnString() { | ||
| return 'methodsReturnString' | ||
| }, | ||
| methodsReturnNumber() { | ||
| return 'methodsReturnNumber' | ||
| }, | ||
| methodsReturnObject() { | ||
| return { | ||
| inside: 'inside' | ||
| } | ||
| }, | ||
| methodsReturnArray() { | ||
| return [1, 2, 3, 4, 5] | ||
| }, | ||
| methodsReturnBoolean() { | ||
| return true | ||
| }, | ||
| methodsReturnFunction() { | ||
| const fn = () => alert('methodsReturnFunction') | ||
| return fn | ||
| }, | ||
| fn() { | ||
| /* Reference data */ | ||
| /* ✓ GOOD */ | ||
| this.computedReturnDataString | ||
| this.computedReturnDataNumber | ||
| this.computedReturnDataObject | ||
| this.computedReturnDataArray | ||
| this.computedReturnDataBoolean | ||
| this.computedReturnDataFunction | ||
| this.computedReturnDataFunction() | ||
| /* ✗ BAD */ | ||
| this.computedReturnDataString() | ||
| this.computedReturnDataNumber() | ||
| this.computedReturnDataObject() | ||
| this.computedReturnDataArray() | ||
| this.computedReturnDataBoolean() | ||
| /* Reference props */ | ||
| /* ✓ GOOD */ | ||
| this.computedReturnPropsString | ||
| this.computedReturnPropsNumber | ||
| this.computedReturnPropsObject | ||
| this.computedReturnPropsArray | ||
| this.computedReturnPropsBoolean | ||
| this.computedReturnPropsFunction | ||
| this.computedReturnPropsFunction() | ||
| /* ✗ BAD */ | ||
| this.computedReturnPropsString() | ||
| this.computedReturnPropsNumber() | ||
| this.computedReturnPropsObject() | ||
| this.computedReturnPropsArray() | ||
| this.computedReturnPropsBoolean() | ||
| /* ✓ GOOD */ | ||
| this.computedReturnObjectPropsString | ||
| this.computedReturnObjectPropsNumber | ||
| this.computedReturnObjectPropsObject | ||
| this.computedReturnObjectPropsArray | ||
| this.computedReturnObjectPropsBoolean | ||
| this.computedReturnObjectPropsFunction | ||
| this.computedReturnObjectPropsFunction() | ||
| /* ✗ BAD */ | ||
| this.computedReturnObjectPropsString() | ||
| this.computedReturnObjectPropsNumber() | ||
| this.computedReturnObjectPropsObject() | ||
| this.computedReturnObjectPropsArray() | ||
| this.computedReturnObjectPropsBoolean() | ||
| /* Reference computed */ | ||
| /* ✓ GOOD */ | ||
| this.computedReturnString | ||
| this.computedReturnNumber | ||
| this.computedReturnObject | ||
| this.computedReturnArray | ||
| this.computedReturnBoolean | ||
| this.computedReturnFunction | ||
| this.computedReturnFunction() | ||
| /* ✗ BAD */ | ||
| this.computedReturnString() | ||
| this.computedReturnNumber() | ||
| this.computedReturnObject() | ||
| this.computedReturnArray() | ||
| this.computedReturnBoolean() | ||
| /* Reference methods */ | ||
| /* ✓ GOOD */ | ||
| this.computedReturnMethodsReturnString | ||
| this.computedReturnMethodsReturnNumber | ||
| this.computedReturnMethodsReturnObject | ||
| this.computedReturnMethodsReturnArray | ||
| this.computedReturnMethodsReturnBoolean | ||
| this.computedReturnMethodsReturnFunction | ||
| this.computedReturnMethodsReturnFunction() | ||
| /* ✗ BAD */ | ||
| this.computedReturnMethodsReturnString() | ||
| this.computedReturnMethodsReturnNumber() | ||
| this.computedReturnMethodsReturnObject() | ||
| this.computedReturnMethodsReturnArray() | ||
| this.computedReturnMethodsReturnBoolean() | ||
| } | ||
| } | ||
| } | ||
| </script> | ||
| ``` | ||
|
|
||
| </eslint-code-block> | ||
|
|
||
| This rule can't check if props is used as array: | ||
|
|
||
| <eslint-code-block :rules="{'vue/no-use-computed-property-like-method': ['error']}"> | ||
|
|
||
| ```vue | ||
| <script> | ||
| export default { | ||
| props: [ | ||
| 'propsString', | ||
| 'propsNumber', | ||
| 'propsObject', | ||
| 'propsArray', | ||
| 'propsBoolean', | ||
| 'propsFunction' | ||
| ], | ||
| computed: { | ||
| computedReturnPropsString() { | ||
| return this.propsString | ||
| }, | ||
| computedReturnPropsNumber() { | ||
| return this.propsNumber | ||
| }, | ||
| computedReturnPropsObject() { | ||
| return this.propsObject | ||
| }, | ||
| computedReturnPropsArray() { | ||
| return this.propsArray | ||
| }, | ||
| computedReturnPropsBoolean() { | ||
| return this.propsBoolean | ||
| }, | ||
| computedReturnPropsFunction() { | ||
| return this.propsFunction | ||
| } | ||
| }, | ||
| methods: { | ||
| fn() { | ||
| /* Reference props */ | ||
| /* ✓ GOOD */ | ||
| this.computedReturnPropsString | ||
| this.computedReturnPropsString() | ||
| this.computedReturnPropsNumber | ||
| this.computedReturnPropsNumber() | ||
| this.computedReturnPropsObject | ||
| this.computedReturnPropsObject() | ||
| this.computedReturnPropsArray | ||
| this.computedReturnPropsArray() | ||
| this.computedReturnPropsBoolean | ||
| this.computedReturnPropsBoolean() | ||
| this.computedReturnPropsFunction | ||
| this.computedReturnPropsFunction() | ||
| /* ✗ BAD */ | ||
| /* Nope. everything is GOOD!! */ | ||
| } | ||
| } | ||
| } | ||
| </script> | ||
| ``` | ||
|
|
||
| </eslint-code-block> | ||
|
|
||
| ## :wrench: Options | ||
|
|
||
| Nothing. | ||
|
|
||
| ## :mag: Implementation | ||
|
|
||
| - [Rule source](https://github.com/vuejs/eslint-plugin-vue/blob/master/lib/rules/no-use-computed-property-like-method.js) | ||
| - [Test source](https://github.com/vuejs/eslint-plugin-vue/blob/master/tests/lib/rules/no-use-computed-property-like-method.js) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.