Add dynamic slots section to key-attribute.md page. #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should hold off on merging this until it is confirmed that this is an intended change. Using a |
NataliaTepluhina
added
the
state: blocked
hc0503
approved these changes
Nov 8, 2020
|
This is now fixed in core. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
Vue 3 now requires a key attribute to be added to a slot with a dynamic name. As far as I can tell this is currently undocumented.
Proposed Solution
I have added a section to the key-attribute.md page to explain this requirement.
I believe this is the correct place, but happy to move it if there's somewhere more suitable.
Additional Information
vuejs/core#2535 from my issue here, it appears this is expected behaviour, so this MR is to document it.