Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _redirects for existing v2 runtime warning links #1832

Merged
merged 3 commits into from
Jul 15, 2022

Conversation

Jinjiang
Copy link
Member

@Jinjiang Jinjiang commented Jul 13, 2022

Description of Problem

Some links from v2 runtime warnings currently are broken like:

https://vuejs.org/guide/computed.html (should be https://v2.vuejs.org/v2/guide/computed.html)
https://vuejs.org/guide/list.html#key (should be https://v2.vuejs.org/v2/guide/list.html#Maintaining-State)

Some of them are already redirected to the v3 doc site, which I think inappropriate:

I added 3 new redirects as comments for further discussion.

Proposed Solution

Additional Information

vuejs/vue#12653

Test links:

https://vuejs.org/guide/computed.html
https://v2.vuejs.org/v2/guide/computed.html

https://vuejs.org/guide/custom-directive.html
https://v2.vuejs.org/v2/guide/custom-directive.html

https://vuejs.org/guide/list.html#key
https://v2.vuejs.org/v2/guide/list.html#Maintaining-State

https://vuejs.org/guide/deployment.html
https://v2.vuejs.org/v2/guide/deployment.html

https://vuejs.org/v2/guide/reactivity.html#Declaring-Reactive-Properties
https://v2.vuejs.org/v2/guide/reactivity.html#Declaring-Reactive-Properties

https://vuejs.org/v2/api/#data
https://v2.vuejs.org/v2/api/#data

https://vuejs.org/v2/guide/components.html#data-Must-Be-a-Function
https://v2.vuejs.org/v2/guide/components.html#data-Must-Be-a-Function

@netlify
Copy link

netlify bot commented Jul 13, 2022

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit 2831cb7
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/62cf28da328b99000aad2e05
😎 Deploy Preview https://deploy-preview-1832--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@NataliaTepluhina NataliaTepluhina merged commit ec001e7 into vuejs:main Jul 15, 2022
@Jinjiang Jinjiang deleted the patch-1 branch July 15, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants